Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework implementation of dpnp.degrees and dpnp.rad2deg functions #1949

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Rework implementation of dpnp.degrees and dpnp.rad2deg functions #1949

merged 4 commits into from
Jul 26, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 26, 2024 •
edited
Loading

The PR proposes to rework implementation of dpnp.rad2deg and dpnp.degrees functions which are quite limited now.
Both functions are completely equivalent to one another.

The implementation is done by adding new binary universal function _degrees to _ufunc_impl pybind11 extension.
The all affected tests are updated to cover different use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vlad-perevezentsev vlad-perevezentsev self-requested a review July 26, 2024 15:04
vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit 264ecb6 into master Jul 26, 2024
38 of 45 checks passed
@antonwolfy antonwolfy deleted the impl-rad2deg-degrees branch July 26, 2024 15:13
github-actions bot added a commit that referenced this pull request Jul 26, 2024
@github-actions
Rework implementation of dpnp.degrees and dpnp.rad2deg functions (#…
78c83e7 
…1949)

* Add implementation of dpnp.degrees() and dpnp.rad2deg()

* Updated note to get rid of invalid link

* Adds more tests 264ecb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev