Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.ediff1d function #1983

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Update dpnp.ediff1d function #1983

merged 4 commits into from
Aug 15, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests updating the dpnp.ediff1d() implementation to make it more readable and adding a new _process_ediff1d_args helper function to reduce duplicate code

Additionally it updates tests to unlock the internal CI cover the new helper function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 13, 2024
View reviewed changes
tests/test_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit b20a352 into master Aug 15, 2024
30 of 45 checks passed
@antonwolfy antonwolfy deleted the fix_ediff1d branch August 15, 2024 08:08
github-actions bot added a commit that referenced this pull request Aug 15, 2024
@github-actions
Update dpnp.ediff1d function (#1983)
8769652 
* Refactor ediff1d function

* Update ediff1d tests

* Apply review comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> b20a352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy