-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import dpnp to be working with numpy 2.0
in the environment
#1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
changed the title
Import dpnp to be working with
Import dpnp to be working with numpy Aug 14, 2024
numpy 2.0
in the environment2.0
in the environment
6 tasks
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
August 18, 2024 10:21
vtavana
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @antonwolfy!
github-actions bot
added a commit
that referenced
this pull request
Aug 19, 2024
* Remove alias on numpy.complex_ * Remove alias on numpy.cfloat * Remove alias on numpy.float and numpy.float_ * Remove alias on numpy.float and numpy.singlecomplex * Remove aliases on numpy.Inf, numpy.Infinity and numpy.infty constants * Get rid of dpnp.float in the code * Remove aliases on numpy.NAN and numpy.NaN constants * Remove aliases on numpy.NINF and numpy.PINF constants * Remove aliases on numpy.NZERO and numpy.PZERO constants 0b7f324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is intended to allow import dpnp package with any numpy from 1.23 to 2.0.
A list of deprecated types and constants were removed since numpy 2.0.
Typically, data type in dpnp is defined as an alias on dtype from numpy. The PR proposes to remove the below dtypes from dpnp, since they are deprecated and removed since numpy 2.0:
The similar approach is used in dpnp for numpy constants. And so the PR will remove aliases on deprecated ones from dpnp code:
All these changes will allow dpnp importing with numpy 2.0 in the environment.
Running dpnp tests scope with numpy 2.0 will be addressed separately.