Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import dpnp to be working with numpy 2.0 in the environment #1985

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 14, 2024

The PR is intended to allow import dpnp package with any numpy from 1.23 to 2.0.

A list of deprecated types and constants were removed since numpy 2.0.

Typically, data type in dpnp is defined as an alias on dtype from numpy. The PR proposes to remove the below dtypes from dpnp, since they are deprecated and removed since numpy 2.0:

  • dpnp.comples_
  • dpnp.cfloat
  • dpnp.float
  • dpnp.float_
  • dpnp.singlecomplex
  • dpnp.longcomplex

The similar approach is used in dpnp for numpy constants. And so the PR will remove aliases on deprecated ones from dpnp code:

  • dpnp.Inf, dpnp.Infinity and dpnp.infty
  • dpnp.NAN and dpnp.NaN
  • dpnp.NINF and dpnp.PINF
  • dpnp.NZERO and dpnp.PZERO

All these changes will allow dpnp importing with numpy 2.0 in the environment.
Running dpnp tests scope with numpy 2.0 will be addressed separately.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 14, 2024
Copy link
Contributor

github-actions bot commented Aug 14, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy changed the title Import dpnp to be working with numpy 2.0 in the environment Import dpnp to be working with numpy 2.0 in the environment Aug 14, 2024
@antonwolfy antonwolfy marked this pull request as ready for review August 18, 2024 10:21
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 0b7f324 into master Aug 19, 2024
36 of 45 checks passed
@antonwolfy antonwolfy deleted the allow-import-numpy-2.0 branch August 19, 2024 08:19
github-actions bot added a commit that referenced this pull request Aug 19, 2024
* Remove alias on numpy.complex_

* Remove alias on numpy.cfloat

* Remove alias on numpy.float and numpy.float_

* Remove alias on numpy.float and numpy.singlecomplex

* Remove aliases on numpy.Inf, numpy.Infinity and numpy.infty constants

* Get rid of dpnp.float in the code

* Remove aliases on numpy.NAN and numpy.NaN constants

* Remove aliases on numpy.NINF and numpy.PINF constants

* Remove aliases on numpy.NZERO and numpy.PZERO constants 0b7f324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants