Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Miniforge installer in GutHub actions #2057

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 17, 2024

Based on information stated here:

With the Miniforge 23.3.1 release, the Miniforge and Mambaforge installers became essentially identical. The only difference between the two was their name and, subsequently, the default installation directory.

The PR proposes to remove miniforge-variant: Mambaforge option from the setup of conda-incubator/setup-miniconda per each affected GitHub action. The removed option will assume to use Miniforge installer inside the actions and will help to get rid of deprecation warning in the logs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review September 17, 2024 08:03
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 3f20511 into master Sep 17, 2024
40 of 46 checks passed
@antonwolfy antonwolfy deleted the use-miniforge-installer-in-public-ci branch September 17, 2024 15:04
antonwolfy added a commit that referenced this pull request Dec 5, 2024
antonwolfy added a commit that referenced this pull request Dec 5, 2024
This PR backports of #2166, #2057 and #2211 from development branch to
`maintenance/0.16.x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants