Replace sycl::free with sycl_free_noexcept
#2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
approved these changes
Sep 17, 2024
antonwolfy
added a commit
that referenced
this pull request
Sep 18, 2024
* Replace sycl::free with sycl_free_noexcept * Update changelog
github-actions bot
added a commit
that referenced
this pull request
Sep 18, 2024
* Replace sycl::free with sycl_free_noexcept * Update changelog a1dedb0
antonwolfy
added a commit
that referenced
this pull request
Sep 18, 2024
* Replace sycl::free with sycl_free_noexcept * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replaces
sycl::freewithdpctl::tensor::alloc_utils::sycl_free_noexceptfrom dpctl tensor headers.Replaced calls to
sycl::freeinhost_taskwith use ofsycl_free_noexcept.This change should improve stability of test suite run executed on CPU device due to a known issue.