Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the test suit for dpnp.fft module #2071

Merged
merged 5 commits into from
Sep 20, 2024
Merged

update the test suit for dpnp.fft module #2071

merged 5 commits into from
Sep 20, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 20, 2024

In this PR, FFT test suite is updated to avoid initializing input arrays with dpnp.empty which might produce invalid data.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana changed the title update dpnp.madule test suite update the test suit for dpnp.fft module Sep 20, 2024
@vtavana vtavana marked this pull request as ready for review September 20, 2024 14:13
antonwolfy
antonwolfy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog also to map to maintenance/0.16.x branch

antonwolfy
antonwolfy reviewed Sep 20, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@vtavana vtavana merged commit c3fe479 into master Sep 20, 2024
43 of 46 checks passed
@vtavana vtavana deleted the update-FFT-test branch September 20, 2024 18:22
vtavana added a commit that referenced this pull request Sep 20, 2024
@vtavana
update the test suit for dpnp.fft module (#2071)
d6baa44 
* update an FFT test

* update changelog.md

* disable too-many-arguments error for pylint

* fix: too-many-positional-arguments

* set a larger value for max-positional-arguments instead of disabling it
vtavana added a commit that referenced this pull request Sep 20, 2024
@vtavana
update the test suit for dpnp.fft module (#2071)
afa239e 
* update an FFT test

* update changelog.md

* disable too-many-arguments error for pylint

* fix: too-many-positional-arguments

* set a larger value for max-positional-arguments instead of disabling it
github-actions bot added a commit that referenced this pull request Sep 20, 2024
@github-actions
update the test suit for dpnp.fft module (#2071)
14b8264 
* update an FFT test

* update changelog.md

* disable too-many-arguments error for pylint

* fix: too-many-positional-arguments

* set a larger value for max-positional-arguments instead of disabling it c3fe479
@vtavana vtavana mentioned this pull request Sep 20, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 20, 2024
@github-actions
backport-gh-2071 7520051
5e84e04
antonwolfy added a commit that referenced this pull request Sep 21, 2024
@antonwolfy
Merge branch 'maintenance/0.16.x' into backport-gh-2071
a902099
github-actions bot added a commit that referenced this pull request Sep 21, 2024
@github-actions
backport-gh-2071 5e01a72
d4ea195
antonwolfy added a commit that referenced this pull request Sep 22, 2024
@vtavana @antonwolfy
update the test suit for dpnp.fft module (#2071) (#2072)
a8370dc 
* update an FFT test

* update changelog.md

* disable too-many-arguments error for pylint

* fix: too-many-positional-arguments

* set a larger value for max-positional-arguments instead of disabling it

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy