update dpnp.reshape to use shape keyword argument instead of newshape
#2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
requested review from
antonwolfy,
npolina4 and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
Oct 1, 2024
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Oct 3, 2024
antonwolfy
reviewed
Oct 3, 2024
antonwolfy
reviewed
Oct 4, 2024
antonwolfy
reviewed
Oct 7, 2024
antonwolfy
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
No more comments from me. Thank you @vtavana for aligning that function with the latest NumPy changes and Python array API.
github-actions bot
added a commit
that referenced
this pull request
Oct 10, 2024
…shape` (#2080) * update using shape argument instead of newshape * Update dpnp/dpnp_iface_manipulation.py Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> * address comments * update dpnp.ravel * minor updates * remove pytest skip --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 63e641f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
dpnp.reshapeanddpnp.ndarray.reshapeare updated to align with changes inNumPy 2.1and support fororder="A"is added.Accordingly,
dpnp.ravelis also updated.