Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of dpnp.linalg.svdvals() #2094

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Add implementation of dpnp.linalg.svdvals() #2094

merged 6 commits into from
Oct 9, 2024
+103 −0

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests adding a new implementation of dpnp.linalg.svdvals() function that was implemented in Numpy 2.0

This function is Array API compatible:

array_api_tests/test_linalg.py::test_svdvals PASSED
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 8, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me.
Thank you @vlad-perevezentsev !

@vlad-perevezentsev vlad-perevezentsev merged commit 7effabc into master Oct 9, 2024
46 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the impl_svdvals branch October 9, 2024 13:19
github-actions bot added a commit that referenced this pull request Oct 9, 2024
@github-actions
Add implementation of dpnp.linalg.svdvals() (#2094)
f66f2a7 
* Add implementation of dpnp.linalg.svdvals

* Add TestSvdvals to test_linalg.py

* Add dpnp.linalg.svdvals to docs

* Update doc/reference/linalg.rst

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 7effabc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy