Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of dpnp.isfortran() #2122

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Add implementation of dpnp.isfortran() #2122

merged 5 commits into from
Oct 24, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests adding an implementation of dpnp.isfortran() to check if the array is Fortran-contiguous using a call to dpnp.ndarray.flags.fnc attribute.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit ff049f9 into master Oct 24, 2024
46 checks passed
@antonwolfy antonwolfy deleted the impl_isfortran branch October 24, 2024 21:26
github-actions bot added a commit that referenced this pull request Oct 24, 2024
@github-actions
Add implementation of dpnp.isfortran() (#2122)
be1861d 
* Add implementation of dpnp.isfortran()

* Enable cupy test for dpnp.isfortran()

* Add more tests

* Address a comment

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> ff049f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy