New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing histogramdd #2143

Merged

AlexanderKalistratov merged 7 commits into IntelPython:master from AlexanderKalistratov:histogramdd

Dec 8, 2024

Collaborator

AlexanderKalistratov commented Oct 31, 2024

Implementing histogramdd

AlexanderKalistratov requested review from antonwolfy, npolina4, vlad-perevezentsev and vtavana as code owners

October 31, 2024 16:04

AlexanderKalistratov force-pushed the histogramdd branch 2 times, most recently from 404f0fe to a108da7 Compare

November 15, 2024 04:42

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_iface_histograms.py Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/statistics/common.hpp Outdated Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/statistics/common.hpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/statistics/common.hpp Outdated Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/statistics/histogram_common.hpp Show resolved Hide resolved

dpnp/backend/extensions/statistics/histogram_common.hpp Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/statistics/histogramdd.hpp Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/statistics/histogramdd.cpp Outdated Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

AlexanderKalistratov force-pushed the histogramdd branch 3 times, most recently from dd1fca3 to 6a7efb0 Compare

November 28, 2024 22:30

AlexanderKalistratov requested a review from antonwolfy

November 29, 2024 14:30

Collaborator Author

AlexanderKalistratov commented Nov 29, 2024

@antonwolfy please re-review PR

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/statistics/common.hpp Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/tests/third_party/cupy/statistics_tests/test_histogram.py Outdated Show resolved Hide resolved

dpnp/tests/third_party/cupy/statistics_tests/test_histogram.py Outdated Show resolved Hide resolved

AlexanderKalistratov force-pushed the histogramdd branch 4 times, most recently from 60776e8 to aec799c Compare

December 4, 2024 14:21

AlexanderKalistratov requested a review from antonwolfy

December 4, 2024 14:23

Collaborator Author

AlexanderKalistratov commented Dec 4, 2024

@antonwolfy please re-review pr

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved

dpnp/tests/third_party/cupy/statistics_tests/test_histogram.py Outdated Show resolved Hide resolved

AlexanderKalistratov added 3 commits

December 6, 2024 04:13


          Implementing histogramdd

34eebcd


          Applying review comments

0fae572


          Aplly review comments 2

ece79cb


          Apply review comments 3

AlexanderKalistratov force-pushed the histogramdd branch from aec799c to 6035300 Compare

December 6, 2024 04:41

Collaborator Author

AlexanderKalistratov commented Dec 6, 2024

The tests failed due to result type mismatch when running with numpy 2.1.
It seems numpy uses different type promotion in the latest version. Is there something we should align with?
Otherwise we have to keep type_check=False.

The actual issue was in returned bins, and not histogram. We are casting all incoming bins and sample to the same type. Originally we were returning this casted bins.

Now if ndarray was passed as part of bins we are returning this original array instead of casted one.

AlexanderKalistratov added 2 commits

December 7, 2024 16:26


          Ignore type if for NumPy >= 2.0.0

f00e8b2


          Merge branch 'master' into histogramdd

6c3da9b

antonwolfy approved these changes

View reviewed changes

Contributor

antonwolfy left a comment

Thank you @AlexanderKalistratov, LGTM!


          Merge branch 'master' into histogramdd

76423ae

AlexanderKalistratov merged commit 0bfe1e3 into IntelPython:master

44 of 49 checks passed

github-actions bot added a commit that referenced this pull request


          Implementing histogramdd (#2143)

e83c2fa

Implementation of histogramdd 0bfe1e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

antonwolfy antonwolfy approved these changes

npolina4 Awaiting requested review from npolina4

vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

vtavana Awaiting requested review from vtavana vtavana is a code owner

Labels

None yet