Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oneMKL version to 0.6 and add new --onemkl-interfaces-dir option #2193

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 22, 2024

The PR proposes to bump oneMKL version up to latest release 0.6.

Also as a validation step it is proposed to add GitHub action with will build dpnp with oneMKL interface on Linux and run tests.
The action is not assumed to be run on Windows, because oneMKL has quite limited support there (i.e. no DFT support).

This PR implements new --onemkl-interfaces-dir= option of python scripts/build_locally.py script to pass a path towards a local checkout directory with oneMKL source.
The action is extended to consider the validation of the new option.

The PR closes #2163.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 22, 2024
@antonwolfy antonwolfy force-pushed the update-onemkl-tag branch 3 times, most recently from fe43949 to 152e847 Compare November 22, 2024 13:19
Copy link
Contributor

github-actions bot commented Nov 22, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the update-onemkl-tag branch 3 times, most recently from e7aa130 to ef28e0e Compare November 22, 2024 14:16
@antonwolfy antonwolfy force-pushed the update-onemkl-tag branch 4 times, most recently from dd79fea to b1469e2 Compare November 22, 2024 16:30
@antonwolfy antonwolfy changed the title Bump oneMKL version to 0.6 Bump oneMKL version to 0.6 and add new --onemkl-interfaces-dir option Nov 22, 2024
@antonwolfy antonwolfy marked this pull request as ready for review November 22, 2024 16:58
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 475c531 into master Nov 22, 2024
46 of 48 checks passed
@antonwolfy antonwolfy deleted the update-onemkl-tag branch November 22, 2024 18:55
github-actions bot added a commit that referenced this pull request Nov 22, 2024
…tion (#2193)

* Bump oneMKL version to 0.6

* Add GH action to check build with oneMKL interfaces

* Add DPNP_ONEMKL_INTERFACES_DIR option 475c531
antonwolfy added a commit that referenced this pull request Dec 5, 2024
…tion (#2193)

* Bump oneMKL version to 0.6

* Add GH action to check build with oneMKL interfaces

* Add DPNP_ONEMKL_INTERFACES_DIR option
antonwolfy added a commit that referenced this pull request Dec 5, 2024
…tion (#2193)

* Bump oneMKL version to 0.6

* Add GH action to check build with oneMKL interfaces

* Add DPNP_ONEMKL_INTERFACES_DIR option
@antonwolfy antonwolfy mentioned this pull request Dec 5, 2024
6 tasks
github-actions bot added a commit that referenced this pull request Dec 5, 2024
github-actions bot added a commit that referenced this pull request Dec 5, 2024
antonwolfy added a commit that referenced this pull request Dec 6, 2024
This PR backports of #2193 from development branch to
`maintenance/0.16.x`.
The new GitHub actions from #2193 is not going to be part of that
backport, because they require some extra functionality to be ported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update oneMKL git tag to the latest version that support 2025 oneAPI.
2 participants