-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump oneMKL version to 0.6
and add new --onemkl-interfaces-dir
option
#2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
force-pushed
the
update-onemkl-tag
branch
3 times, most recently
from
November 22, 2024 13:19
fe43949
to
152e847
Compare
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
update-onemkl-tag
branch
3 times, most recently
from
November 22, 2024 14:16
e7aa130
to
ef28e0e
Compare
antonwolfy
force-pushed
the
update-onemkl-tag
branch
4 times, most recently
from
November 22, 2024 16:30
dd79fea
to
b1469e2
Compare
antonwolfy
changed the title
Bump oneMKL version to
Bump oneMKL version to Nov 22, 2024
0.6
0.6
and add new --onemkl-interfaces-dir
option
antonwolfy
force-pushed
the
update-onemkl-tag
branch
from
November 22, 2024 16:47
b1469e2
to
13ca3df
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
November 22, 2024 16:58
vtavana
reviewed
Nov 22, 2024
vtavana
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @antonwolfy!
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
…tion (#2193) * Bump oneMKL version to 0.6 * Add GH action to check build with oneMKL interfaces * Add DPNP_ONEMKL_INTERFACES_DIR option
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
…tion (#2193) * Bump oneMKL version to 0.6 * Add GH action to check build with oneMKL interfaces * Add DPNP_ONEMKL_INTERFACES_DIR option
antonwolfy
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to bump oneMKL version up to latest release
0.6
.Also as a validation step it is proposed to add GitHub action with will build dpnp with oneMKL interface on Linux and run tests.
The action is not assumed to be run on Windows, because oneMKL has quite limited support there (i.e. no DFT support).
This PR implements new
--onemkl-interfaces-dir=
option ofpython scripts/build_locally.py
script to pass a path towards a local checkout directory with oneMKL source.The action is extended to consider the validation of the new option.
The PR closes #2163.