Introduce DPNP_WITH_REDIST cmake option
#2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e preceding comment
antonwolfy
force-pushed
the
support-redist-runpath
branch
from
d5c2411 to
450e4e8
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
support-redist-runpath
branch
from
450e4e8 to
4113020
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
|
I've checked both wheels installed from internal CI and from public CI and it seems to install and import dpnp correctly. |
vlad-perevezentsev
approved these changes
Dec 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 2, 2024
The PR proposes to introduce `DPNP_WITH_REDIST` cmake options, defaulting to `OFF`. If set, cmake script add to RUNPATH an entry relative to `$ORIGIN` that would point to `$PREFIX/lib`, hence allowing native extensions to find DPC++ redistributable libraries. `conda-recipe/build.sh` is modified to set `DPNP_WITH_REDIST=TRUE`. It closes #2200. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft? 0bac735
vtavana
pushed a commit
that referenced
this pull request
Dec 2, 2024
The PR proposes to introduce `DPNP_WITH_REDIST` cmake options, defaulting to `OFF`. If set, cmake script add to RUNPATH an entry relative to `$ORIGIN` that would point to `$PREFIX/lib`, hence allowing native extensions to find DPC++ redistributable libraries. `conda-recipe/build.sh` is modified to set `DPNP_WITH_REDIST=TRUE`. It closes #2200. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft?
vtavana
pushed a commit
that referenced
this pull request
Dec 2, 2024
The PR proposes to introduce `DPNP_WITH_REDIST` cmake options, defaulting to `OFF`. If set, cmake script add to RUNPATH an entry relative to `$ORIGIN` that would point to `$PREFIX/lib`, hence allowing native extensions to find DPC++ redistributable libraries. `conda-recipe/build.sh` is modified to set `DPNP_WITH_REDIST=TRUE`. It closes #2200. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft?
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
The PR proposes to introduce `DPNP_WITH_REDIST` cmake options, defaulting to `OFF`. If set, cmake script add to RUNPATH an entry relative to `$ORIGIN` that would point to `$PREFIX/lib`, hence allowing native extensions to find DPC++ redistributable libraries. `conda-recipe/build.sh` is modified to set `DPNP_WITH_REDIST=TRUE`. It closes #2200. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft?
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to introduce
DPNP_WITH_REDISTcmake options, defaulting toOFF.If set, cmake script add to RUNPATH an entry relative to
$ORIGINthat would point to$PREFIX/lib, hence allowing native extensions to find DPC++ redistributable libraries.conda-recipe/build.shis modified to setDPNP_WITH_REDIST=TRUE.It closes #2200.