Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cupy doc to intersphinx_mapping #2232

Merged
merged 2 commits into from
Dec 13, 2024
Merged

add cupy doc to intersphinx_mapping #2232

merged 2 commits into from
Dec 13, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Dec 13, 2024 •
edited
Loading

In this PR, cupy documentation is added to intersphinx_mapping in doc/conf.py. With this change, references to cupy functions in comparison table become clickable.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review December 13, 2024 16:33
@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2024 •
edited
Loading

Coverage Status

coverage: 65.09%. remained the same
when pulling 594c4fb on add-cupy-to-intersphinx_mapping
into cf2a106 on master.

antonwolfy
antonwolfy approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit 5096a7d into master Dec 13, 2024
47 of 48 checks passed
@vtavana vtavana deleted the add-cupy-to-intersphinx_mapping branch December 13, 2024 20:14
github-actions bot added a commit that referenced this pull request Dec 13, 2024
@github-actions
Merge pull request #2232 from IntelPython/add-cupy-to-intersphinx_map…
ff088e3 
…ping

add cupy doc to `intersphinx_mapping` 5096a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy