update tests for newly added integr dtypes (int8, int16, uint8-uint64) #2233

vtavana · 2024-12-13T16:18:26Z

In this PR, tests are update to pass with newly added integer dtypes (int8, int16, uint8, uint16, uint32, uint64).
This PR is in continuation of #2230.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?

github-actions · 2024-12-13T22:08:10Z

View rendered docs @ https://intelpython.github.io/dpnp/pull/2233/index.html

DPC++ compiler released 2025.0.4 version where `__SYCL_COMPILER_VERSION` is defined to `20241205`. But the fixes from #2211 and for `sycl::ext::intel::math::cyl_bessel_i0(x)` support weren't mapped there. Thus the PR proposes to bump `__SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT` and `__SYCL_COMPILER_BESSEL_I0_SUPPORT` defines up to `20241210` value to exclude DPC++ compiler 2025.0.4 version.

The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows.

dpnp/fft/dpnp_utils_fft.py

dpnp/tests/test_sum.py

dpnp/dpnp_iface_linearalgebra.py

dpnp/tests/test_amin_amax.py

dpnp/tests/test_histogram.py

dpnp/tests/test_mathematical.py

dpnp/tests/third_party/cupy/testing/_loops.py

This PR suggests updating the helper function `generate_random_numpy_array()` by adding an argument `order` to generate arrays in different orders Additionally Input generation for tests was changed in #2227 , now `test_fft2` and `test_fftn` do not use `order` parameter. This PR suggests to update these tests to use input data with different orders.

dpnp/tests/test_histogram.py

dpnp/tests/test_indexing.py

dpnp/tests/test_mathematical.py

dpnp/tests/test_product.py

dpnp/tests/test_sum.py

antonwolfy

Thank you @vtavana , LGTM

vtavana self-assigned this Dec 13, 2024

vtavana force-pushed the fix-test_product-for-new-dtypes branch from 00ed47d to 9b4c5a9 Compare December 17, 2024 02:27

antonwolfy and others added 4 commits December 16, 2024 19:38

update tests for newly added integr dtypes (int8, int16, uint8-uint64)

fc249e1

run linux tests in serial

fc64fa4

vtavana force-pushed the fix-test_product-for-new-dtypes branch from 2357a7c to fc64fa4 Compare December 17, 2024 03:41

vtavana marked this pull request as ready for review December 17, 2024 04:53

vtavana requested review from antonwolfy, AlexanderKalistratov and vlad-perevezentsev as code owners December 17, 2024 04:53

antonwolfy reviewed Dec 17, 2024

View reviewed changes

vlad-perevezentsev and others added 3 commits December 17, 2024 06:38

address comments

6881425

test_over_index

b913df8

vtavana mentioned this pull request Dec 17, 2024

update third party tests for newly added integr dtypes (int8, int16, uint8-uint64) #2239

Open

6 tasks