Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dpnp in virtual environment on Windows out of the box #2242

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 19, 2024

Since location of "Library\bin" in the virtual environment is not on the default search path, importing of dpnp fails due to unmet dependencies towards oneMKL libraries.

The PR proposes to extend "PATH" environment on Windows in the virtual environment with a path to "Library\bin" directory.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Dec 19, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 65.06% (-0.01%) from 65.074%
when pulling c87e9c8 on support-venv-windows
into cabc0d7 on master.

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you @antonwolfy !

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@antonwolfy antonwolfy merged commit fdde3d0 into master Dec 19, 2024
37 of 42 checks passed
@antonwolfy antonwolfy deleted the support-venv-windows branch December 19, 2024 22:37
antonwolfy added a commit that referenced this pull request Dec 19, 2024
Since location of "Library\bin" in the virtual environment is not on the
default search path, importing of `dpnp` fails due to unmet dependencies
towards oneMKL libraries.

The PR proposes to extend `"PATH"` environment on Windows in the virtual
environment with a path to `"Library\bin"` directory.
@antonwolfy antonwolfy mentioned this pull request Dec 19, 2024
6 tasks
github-actions bot added a commit that referenced this pull request Dec 19, 2024
Since location of "Library\bin" in the virtual environment is not on the
default search path, importing of `dpnp` fails due to unmet dependencies
towards oneMKL libraries.

The PR proposes to extend `"PATH"` environment on Windows in the virtual
environment with a path to `"Library\bin"` directory. fdde3d0
antonwolfy added a commit that referenced this pull request Dec 19, 2024
This PR backports of #2242 from development branch to
`maintenance/0.16.x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants