-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete dpnp.cov
implementation
#2303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_22 ran successfully. |
vtavana
reviewed
Feb 13, 2025
vtavana
reviewed
Feb 13, 2025
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
vtavana
reviewed
Feb 13, 2025
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
vtavana
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @antonwolfy!
github-actions bot
added a commit
that referenced
this pull request
Feb 13, 2025
The PR proposes to rework implementation of `dpnp.cov` and to add support of all missing keywords, replace TODO with already supported functionality and to remove any fallback on numpy call. Also this PR update documentation and adds extra tests to improve the coverage. 0403a7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to rework implementation of
dpnp.cov
and to add support of all missing keywords, replace TODO with already supported functionality and to remove any fallback on numpy call.Also this PR update documentation and adds extra tests to improve the coverage.