Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete dpnp.cov implementation #2303

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Complete dpnp.cov implementation #2303

merged 13 commits into from
Feb 13, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 10, 2025

The PR proposes to rework implementation of dpnp.cov and to add support of all missing keywords, replace TODO with already supported functionality and to remove any fallback on numpy call.
Also this PR update documentation and adds extra tests to improve the coverage.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_22 ran successfully.
Passed: 976
Failed: 1
Skipped: 23

@antonwolfy antonwolfy marked this pull request as ready for review February 12, 2025 10:11
antonwolfy and others added 3 commits February 13, 2025 12:42
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 0403a7c into master Feb 13, 2025
68 of 70 checks passed
@antonwolfy antonwolfy deleted the complete-cov-impl branch February 13, 2025 15:59
github-actions bot added a commit that referenced this pull request Feb 13, 2025
The PR proposes to rework implementation of `dpnp.cov` and to add
support of all missing keywords, replace TODO with already supported
functionality and to remove any fallback on numpy call.
Also this PR update documentation and adds extra tests to improve the
coverage. 0403a7c
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.736%. first build
when pulling 1cd31b2 on complete-cov-impl
into 0bda96a on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants