Skip to content

Enable array API advanced indexing tests #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Enable array API advanced indexing tests #2414

merged 2 commits into from
Apr 10, 2025
+0 −6

Conversation

ndgrigorian
Copy link
Collaborator

dpctl.tensor now conforms to array API 2024.12 indexing, so tests can be run

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@ndgrigorian
Enable advanced indexing tests
aedca16 
dpctl.tensor now conforms to array API 2024.12 indexing, so tests can be run
@ndgrigorian ndgrigorian force-pushed the enable-array-api-advanced-indexing-tests branch from 956a560 to aedca16 Compare April 9, 2025 21:36
@ndgrigorian ndgrigorian marked this pull request as draft April 9, 2025 21:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 9, 2025 •
edited
Loading

Coverage Status

coverage: 72.271%. remained the same
when pulling d83ca7d on enable-array-api-advanced-indexing-tests
into 0ab1d62 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_75 ran successfully.
Passed: 1219
Failed: 0
Skipped: 10

@ndgrigorian ndgrigorian marked this pull request as ready for review April 9, 2025 23:15
antonwolfy
antonwolfy approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 15ed961 into master Apr 10, 2025
67 checks passed
@ndgrigorian ndgrigorian deleted the enable-array-api-advanced-indexing-tests branch April 10, 2025 15:12
github-actions bot added a commit that referenced this pull request Apr 10, 2025
@github-actions
Merge pull request #2414 from IntelPython/enable-array-api-advanced-i…
9bff199 
…ndexing-tests

Enable array API advanced indexing tests 15ed961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy

@vtavana vtavana

@AlexanderKalistratov AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndgrigorian @coveralls @antonwolfy @vtavana