Skip to content

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 15, 2025

The PR excludes the headers files under backend/kernels/elementwise_functions from the coverage report, because there is no way to cover structures used inside the SYCL kernels.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 15, 2025
@antonwolfy antonwolfy self-assigned this Oct 15, 2025
Copy link
Contributor

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_13 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2623/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 74.387% (+6.6%) from 67.791%
when pulling fea1842 on exclude-kernels-headers-from-default-coverage
into fc14877 on master.

@antonwolfy antonwolfy marked this pull request as ready for review October 15, 2025 16:46
"export",
"-format=lcov",
"-ignore-filename-regex=/tmp/icpx*",
r"-ignore-filename-regex=.*/backend/kernels/elementwise_functions/.*\.hpp$",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also kernels in extensions which will have to be ignored

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that in the follow up PR, because they have to be separated to dedicated headers first. Otherwise it's impossible to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants