Skip to content

Rename nrt_debug_print -> drt_debug_print #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2023
Merged

Rename nrt_debug_print -> drt_debug_print #1002

merged 1 commit into from
Apr 15, 2023

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 14, 2023

Numba package updated syntax for nrt_debug_print, which caused issues on compilation time. This PR renames function in order to be able to compile for both versions of numba and be more reliable on numba updates.

#1000

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Apr 14, 2023
diptorupd
diptorupd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZzEeKkAa ZzEeKkAa merged commit 31ec311 into main Apr 15, 2023
@ZzEeKkAa ZzEeKkAa deleted the fix/nrt_debug_print branch April 15, 2023 00:09
github-actions bot added a commit that referenced this pull request Apr 15, 2023
@github-actions
Merge pull request #1002 from IntelPython/fix/nrt_debug_print 31ec311
329b737
@diptorupd diptorupd mentioned this pull request Apr 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzEeKkAa @diptorupd