Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design change from using NumPy expressions and
device_contexttodpnpoffload via the newdpjitdecorator introduced in 0.20 has made several previously added experimental features of numba-dpex superfluous. The PR removes the following code in order to reduce cruft and simplify the code base. Some of the removed features and corresponding code will be brought back after suitable redesign and refactoring:njitfunction. These overloads have not been updated to latest dpnp. Moreover, some of these overloads are for functions where dpnp falls back to NumPy. Overloads for dpnp for modules such aslinalgandrandomwill be added back post a redesign.dpjit, the rename passes will not be required.dpctl.device_context. Asdevice_contextis no longer used and all offload is determined via compute-follows-data programming model the module is no longer required.Few things that are not yet removed are:
lowerer.py and dpctl_iface: Both are blocked by Remove usage of lower_extensions #1028
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?
I will add some unit tests and reorganize the commits.
Superseded by #1041