Skip to content

Conversation

@mingjie-intel
Copy link
Contributor

@mingjie-intel mingjie-intel commented May 25, 2023

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

As #885 , spirv-max-version is limited to 1.1 to avoid with oneAPI dpcpp 2023.0. While infra team is updating spirv headers to 1.4, as part of Numba 0.57 upgrade, numba-dpex needs to lift the limit and support spirv 1.4.

@diptorupd
Copy link
Contributor

No issues as such, but the PR needs some context as to why the change is needed.

@mingjie-intel
Copy link
Contributor Author

No issues as such, but the PR needs some context as to why the change is needed.

Updated.

@diptorupd diptorupd merged commit bc46319 into main May 26, 2023
@diptorupd diptorupd deleted the spirv_version branch May 26, 2023 14:42
github-actions bot added a commit that referenced this pull request May 26, 2023
Upgraded spirv-max-version from 1.1 to 1.4. bc46319
github-actions bot added a commit to chudur-budur/numba-dpex that referenced this pull request May 26, 2023
Upgraded spirv-max-version from 1.1 to 1.4. bc46319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants