Skip to content

Cleanup redundant code #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2020
Merged

Cleanup redundant code #139

merged 3 commits into from
Dec 23, 2020

Conversation

@reazulhoque
Copy link
Contributor

@reazulhoque reazulhoque commented Dec 23, 2020

This PR refactors code to reduce redundancy and improves reuse.

PokhodenkoSA
PokhodenkoSA reviewed Dec 23, 2020
View reviewed changes
PokhodenkoSA
PokhodenkoSA approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reazulhoque reazulhoque merged commit 2d100c5 into IntelPython:main Dec 23, 2020
@reazulhoque reazulhoque deleted the cleanup/dpnp_integration_cleanup branch December 23, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

1 more reviewer

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reazulhoque @PokhodenkoSA