Skip to content

Pass dpnp arrays directly to kernel instead of using dpctl.asarray. #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Pass dpnp arrays directly to kernel instead of using dpctl.asarray. #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 5 additions & 39 deletions numba_dpex/tests/integration/test_dpnp_interop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@
#
# SPDX-License-Identifier: Apache-2.0

import dpctl
import numpy as np
import pytest

import numba_dpex as dpex
from numba_dpex.tests._helper import filter_strings

dpnp = pytest.importorskip("dpnp", reason="DPNP is not installed")

Expand All @@ -25,38 +23,7 @@ def dtype(request):
return request.param


list_of_usm_type = [
"shared",
"device",
"host",
]


@pytest.fixture(params=list_of_usm_type)
def usm_type(request):
return request.param


@pytest.mark.parametrize("filter_str", filter_strings)
def test_dpnp_create_array_in_context(filter_str, dtype):
if (
"opencl" not in dpctl.get_current_queue().sycl_device.filter_string
and "opencl" in filter_str
):
pytest.skip("Bug in DPNP. See: IntelPython/dpnp#723")

with dpctl.device_context(filter_str):
a = dpnp.arange(1024, dtype=dtype) # noqa


@pytest.mark.parametrize("filter_str", filter_strings)
def test_consuming_array_from_dpnp(filter_str, dtype):
if (
"opencl" not in dpctl.get_current_queue().sycl_device.filter_string
and "opencl" in filter_str
):
pytest.skip("Bug in DPNP. See: IntelPython/dpnp#723")

def test_consuming_array_from_dpnp(dtype):
@dpex.kernel
def data_parallel_sum(a, b, c):
"""
Expand All @@ -67,9 +34,8 @@ def data_parallel_sum(a, b, c):

global_size = 1021

with dpctl.device_context(filter_str):
a = dpex.asarray(dpnp.arange(global_size, dtype=dtype))
b = dpex.asarray(dpnp.arange(global_size, dtype=dtype))
c = dpex.asarray(dpnp.ones_like(a))
a = dpnp.arange(global_size, dtype=dtype)
b = dpnp.arange(global_size, dtype=dtype)
c = dpnp.ones_like(a)

data_parallel_sum[global_size, dpex.DEFAULT_LOCAL_SIZE](a, b, c)
data_parallel_sum[global_size](a, b, c)