Skip to content

Fix dpnp type #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 22, 2023
Merged

Fix dpnp type #880

merged 12 commits into from
Jan 22, 2023

Conversation

@mingjie-intel
Copy link
Contributor

@mingjie-intel mingjie-intel commented Jan 19, 2023 •
edited by diptorupd
Loading

  1. Moved dpnp types.py typesof.py into core.
  2. Let dpnp ndarray inherite from USM ndarray.

Fixes #857

diptorupd
diptorupd reviewed Jan 19, 2023
View reviewed changes
diptorupd
diptorupd reviewed Jan 19, 2023
View reviewed changes
@diptorupd diptorupd mentioned this pull request Jan 19, 2023
Closed
diptorupd
diptorupd reviewed Jan 19, 2023
View reviewed changes
diptorupd
diptorupd reviewed Jan 19, 2023
View reviewed changes
@diptorupd diptorupd mentioned this pull request Jan 20, 2023
Closed
5 tasks
@diptorupd diptorupd force-pushed the fix/dpnp_type branch 4 times, most recently from 5ce8123 to 392afd3 Compare January 21, 2023 03:01
@diptorupd diptorupd mentioned this pull request Jan 21, 2023
Closed
@diptorupd diptorupd force-pushed the fix/dpnp_type branch 2 times, most recently from b6fc828 to 87a40ad Compare January 21, 2023 22:23
This was referenced Jan 21, 2023
Closed
Merged
Diptorup Deb and others added 12 commits January 21, 2023 20:59
Pass dpnp arrays directly to kernel instead of using dpctl.asarray.
92914dd
@mingjie-intel
Fixed dpnp type which was causing test_dpnp_interop.py to fail.
eb2e1ab
@mingjie-intel
Replaced dpnp_Ndarray_Type with DpnpNdarray.
f92e66b
@mingjie-intel
Renamed dpnp_ndarray_types.py to dpnp_ndarray_type.py.
759bde5
Ensure that the typeof for dpnp.ndarray returns the new DpnpNdarray t…
ca789bc 
…ype.
Remove numpy_usm_shared check from test_dpnp_ndarray_type.
38953f5
@mingjie-intel
Renamed DpnpNdarray to DpnpNdArray.
3ba0eb2 
Removed duplicated test, test_typeof.py.
Fix failing example. Dpctl treats scalars as 0D arrays, needing conve…
c13adaa 
…rsion to int.
Move the data model for DpnpNdArray into core.
7e9f1a4
Remove redundant examples.
0e17831
Skip running vector_sum2D in CI till the issue with multi-dimensional…
13132f0 
… indexing is fixed.
Fix Github Windows CI.
cb96e20
@diptorupd diptorupd merged commit 1b7cbc3 into main Jan 22, 2023
@diptorupd diptorupd deleted the fix/dpnp_type branch January 22, 2023 03:33
github-actions bot added a commit that referenced this pull request Jan 22, 2023
@github-actions
Merge pull request #880 from IntelPython/fix/dpnp_type
58eb122 
Changes to the Numba type to represent dpnp ndarray types.
Various changes to fix GitHub CI workflows. 1b7cbc3
github-actions bot pushed a commit that referenced this pull request Jan 22, 2023
@diptorupd
Merge pull request #880 from IntelPython/fix/dpnp_type
593c7a0 
Changes to the Numba type to represent dpnp ndarray types.
Various changes to fix GitHub CI workflows. 1b7cbc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dpex failed to call dpnp.ones_like()

2 participants

@mingjie-intel @diptorupd