Implementation for dpnp.full() #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

diptorupd merged 1 commit into IntelPython:main from chudur-budur:feature/dpnp.full

Apr 14, 2023

Contributor

chudur-budur commented Apr 6, 2023 •

edited

Loading

Implementation for dpnp.full().

This will enable calling dpnp.full() inside @dpjit functions.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?

Contributor Author

chudur-budur commented Apr 6, 2023 •

edited

Loading

~~Just look into the driver.py, it's self-contained.~~

The implementations are in _intrinsic.py and arrayobj.py

chudur-budur force-pushed the feature/dpnp.full branch 4 times, most recently from e96fa5b to 61daa73 Compare

April 12, 2023 01:53

Contributor Author

chudur-budur commented Apr 12, 2023

keeping track on #254

chudur-budur mentioned this pull request

Supporting dpnp array creation functions inside dpjit #254

Open

20 tasks

chudur-budur marked this pull request as ready for review

April 12, 2023 02:00

chudur-budur requested review from diptorupd and mingjie-intel as code owners

April 12, 2023 02:00

chudur-budur changed the title ~~WIP for dpnp.full()~~ Implementation for dpnp.full()

chudur-budur force-pushed the feature/dpnp.full branch 3 times, most recently from 66256b7 to 5da25f1 Compare

April 12, 2023 15:26

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/_dpexrt_python.c Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/_dpexrt_python.c Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/_dpexrt_python.c Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/_dpexrt_python.c Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/_dpexrt_python.c Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/context.py Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/core/runtime/context.py Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/arrayobj.py Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/arrayobj.py Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/arrayobj.py Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

numba_dpex/dpnp_iface/arrayobj.py Show resolved Hide resolved

chudur-budur force-pushed the feature/dpnp.full branch 2 times, most recently from d2e8141 to 54ae6ee Compare

April 13, 2023 23:26

diptorupd approved these changes

View reviewed changes

Contributor

diptorupd left a comment

Thank you!


          Overload implementation for dpnp.full()

751da72

    - Adds an overload implementation for dpnp.full
    - Removes the  `like` kwarg from dpnp.empty() overload
    - Unit test cases

diptorupd force-pushed the feature/dpnp.full branch from c8e834e to 751da72 Compare

April 14, 2023 14:56

diptorupd merged commit 3ded18e into IntelPython:main

diptorupd deleted the feature/dpnp.full branch

April 14, 2023 17:44

github-actions bot added a commit that referenced this pull request


          Merge pull request #991 from chudur-budur/feature/dpnp.full

c6172b6

Implementation for dpnp.full() 3ded18e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet