add NO_TLS for FastDDS builds to disable SSL linkage #12943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0c96dce)
Nir-Az
approved these changes
May 20, 2024
|
I assume you ran a release flow and tried the python wheels? :) |
Yes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with
SECURITYset to OFF, if FastDDS detects OpenSSL then it tries to link withlibssl. Our build machines have OpenSSL and are compiled on non-Jammy machines, so this results in a dependency onlibssl1.1which is deprecated with Jammy so librealsense cannot be loaded.eProsima indicates the proper way to disable this is to set
NO_TLStoON.Tracked on [RSDEV-2112]