Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_option api checking range restored #13328

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

remibettan
Copy link
Contributor

Tracked by: RSDEV-2638

@remibettan remibettan requested a review from OhadMeir September 9, 2024 08:27
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test trying to set invalid values

@remibettan
Copy link
Contributor Author

Please add unit test trying to set invalid values

Added

@remibettan remibettan requested a review from OhadMeir September 9, 2024 12:00
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Nir-Az Nir-Az merged commit 0e8c151 into IntelRealSense:development Sep 10, 2024
20 checks passed
@Nir-Az
Copy link
Collaborator

Nir-Az commented Sep 10, 2024

Tested with D400 + D555 Eth.

As discussed, since we with to have a range check in the API, we return this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants