C# and Unity wrappers #2559
Closed
C# and Unity wrappers #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Object pooling for frames and profiles * Fixed a bug where PlaybackDevice disposed the underlying device * Removed custom FrameSet marshaler * Add ICompositeDisposable interface to FrameReleaser and FrameSet * Processing blocks callbacks are marshalled through native user-data pointers, avoiding closure allocation * Added missing Format.Disparity32 * Added Option interfaces (IOption, IOptions, IOptionsContainer) * Added IEnumerable<Frame> to Pipeline
* Downgrade project version to 2017.4 LTS * VideoFrame to Texture2D uses FrameQueue and uploads data straight to GPU * Fixed stream configuration being reset when recording * Multi device support (via RsFrameProvider) * Processing blocks are now asset based, their options are persistent and they have a dedicated inspector UI.
Merged
matkatz
reviewed
Oct 21, 2018
| @@ -77,8 +77,8 @@ public override void OnInspectorGUI() | |||
|
|
|||
| EditorGUILayout.Space(); | |||
| EditorGUILayout.PropertyField(config.FindPropertyRelative("Profiles"), true); | |||
| EditorGUILayout.Space(); | |||
| EditorGUILayout.PropertyField(serializedObject.FindProperty("_processingPipe"), false); | |||
| // EditorGUILayout.Space(); | |||
matkatz
reviewed
Oct 21, 2018
| } | ||
|
|
||
| public override List<Stream> Requirments() | ||
| void Update() |
There was a problem hiding this comment.
why don't you use setters instead of Update?
matkatz
reviewed
Oct 21, 2018
| { | ||
| if (a == this) | ||
| continue; | ||
| // Debug.Log(a, a); |
matkatz
reviewed
Oct 21, 2018
|
|
||
| private Colorizer _pb; | ||
|
|
||
| public VisualPreset visualPreset = VisualPreset.Dynamic; |
matkatz
reviewed
Oct 21, 2018
| [ProcessingBlockData(typeof(DepthCutoff))] | ||
| public class DepthCutoff : RsProcessingBlock | ||
| { | ||
| public ushort Distance = 1000; |
matkatz
reviewed
Oct 21, 2018
| @@ -31,40 +35,57 @@ public class RsTemporalFilter : RsProcessingBlock | |||
| [Range(0, 8)] | |||
matkatz
reviewed
Oct 21, 2018
| /// </summary> | ||
| public enum ProcessMode | ||
| { | ||
| Multithread, | ||
| UnityThread, | ||
| } | ||
|
|
||
| public static RsDevice Instance { get; private set; } | ||
| // public static RsDevice Instance { get; private set; } |
matkatz
reviewed
Oct 21, 2018
| } | ||
| } | ||
|
|
||
| // using (var p = frame.Profile) |
matkatz
reviewed
Oct 21, 2018
| { | ||
| object error; | ||
| m_instance = new HandleRef(this, NativeMethods.rs2_create_frame_queue(capacity, out error)); | ||
| } | ||
|
|
||
| public bool PollForFrame(out Frame frame, FramesReleaser releaser = null) | ||
| public bool PollForFrame(out Frame frame) |
matkatz
reviewed
Oct 21, 2018
| @@ -98,6 +98,10 @@ internal static class NativeMethods | |||
| [DllImport(dllName, CallingConvention = CallingConvention.Cdecl)] | |||
| internal static extern IntPtr rs2_create_processing_block_fptr([MarshalAs(UnmanagedType.FunctionPtr)] frame_processor_callback on_frame, IntPtr user, [MarshalAs(UnmanagedType.CustomMarshaler, MarshalTypeRef = typeof(Helpers.ErrorMarshaler))] out object error); | |||
|
|
|||
| internal static void rs2_get_video_stream_resolution(IntPtr ptr, out object width, out object height, out object error) | |||
|
I think that we can merge this one together with #2561 which fix a crash in the SW device example, update the documentation and fix few issues in the processing blocks in the unity project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C#
Object pooling for frames and profiles
Fixed a bug where PlaybackDevice disposed the underlying device
Removed custom FrameSet marshaler
Add ICompositeDisposable interface to FrameReleaser and FrameSet
Processing blocks callbacks are marshalled through native user-data pointers, avoiding closure allocation
Added missing Format.Disparity32
Added Option interfaces (IOption, IOptions, IOptionsContainer)
Added IEnumerable to Pipeline
UNITY
Downgrade project version to 2017.4 LTS
VideoFrame to Texture2D uses FrameQueue and uploads data straight to GPU
Fixed stream configuration being reset when recording
Multi device support (via RsFrameProvider)
Processing blocks are now asset based, their options are persistent and they have a dedicated inspector UI.