Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative, possibly simpler approach for obtaining pitch, roll and … #5198

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Conversation

neilyoung
Copy link
Contributor

…yaw from T265 pose in python

@radfordi
Copy link
Contributor

radfordi commented Nov 6, 2019

Thanks @neilyoung. I'd be fine with replacing t265_rpy.py with this version. @schmidtp1?

@neilyoung
Copy link
Contributor Author

@radfordi I didn't mean to be so presumptuous, that's why the alternative. But I tested for equivalence. Everything seems to be fine. For the previous version there was another variant somewhere in the issues, which also covered the case of the camera pointing downwards. I didn't test this case.

@dorodnic dorodnic added python T260 series Intel® T265 library labels Nov 11, 2019
@dorodnic
Copy link
Contributor

Hi @neilyoung
Thanks for the patch! Could you please rename the file to override existing t265_rpy.py?

@neilyoung
Copy link
Contributor Author

@dorodnic Done

@dorodnic
Copy link
Contributor

Thank you
@schmidtp1 @bfulkers-i - any objections?

2. Install the Homebrew package manager via terminal - [link](http://brew.sh/)
3. Install the following packages via brew:
* `brew install cmake libusb pkg-config`
* `brew cask install vulkan-sdk`
* `brew cask install apenngrace/vulkan/vulkan-sdk`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorodnic, can we just remove this line? Or move it to it's own "Optional" section? The vulkan-sdk is not required. Maybe we should suggest brew install vulkan-headers instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't originally in the guide (and to my understanding not supposed to be), but people reported it helped them with GLFW compilation

@dorodnic dorodnic merged commit 0a75567 into IntelRealSense:development Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python T260 series Intel® T265 library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants