-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FW update exception fix #8018
Merged
+45
−0
Merged
FW update exception fix #8018
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b044ad1
FW update exception fix
nohayassin 68cc349
Merge branch 'development' of https://github.com/IntelRealSense/libre…
nohayassin 73186ba
FW update exception fix, SR3 device
nohayassin f947976
dso_16069_fw_update increase loops to 50
nohayassin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -435,12 +435,26 @@ namespace librealsense | |
{ | ||
// Stop all data streaming/exchange pipes with HW | ||
stop_activity(); | ||
using namespace std; | ||
using namespace std::chrono; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this case use of explicit std::this_thread... |
||
|
||
try { | ||
LOG_INFO("entering to update state, device disconnect is expected"); | ||
command cmd(ivcam2::DFU); | ||
cmd.param1 = 1; | ||
_hw_monitor->send(cmd); | ||
std::vector<uint8_t> gvd_buff(HW_MONITOR_BUFFER_SIZE); | ||
for (auto i = 0; i < 50; i++) | ||
{ | ||
|
||
_hw_monitor->get_gvd(gvd_buff.size(), gvd_buff.data(), GVD); | ||
this_thread::sleep_for(milliseconds(50)); | ||
} | ||
throw std::runtime_error("Device still connected!"); | ||
|
||
} | ||
catch (std::exception& e) { | ||
LOG_WARNING(e.what()); | ||
} | ||
catch (...) { | ||
// The set command returns a failure because switching to DFU resets the device while the command is running. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reword with "Device failed to switch to DFU within the predefined time"