Live555 version freeze. #8282
Merged
Live555 version freeze. #8282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengyui
reviewed
Feb 1, 2021
| @@ -361,11 +361,6 @@ void ip_device::inject_frames_loop(std::shared_ptr<rs_rtp_stream> rtp_stream) | |||
| rtp_stream.get()->is_enabled = true; | |||
|
|
|||
| rtp_stream.get()->frame_data_buff.frame_number = 0; | |||
|
|
|||
| /// FIXME: bbp and stride should be filled by m_rs_stream. but There are something wrong in m_rs_stream. | |||
There was a problem hiding this comment.
Please keep this workaround until fix get_stride_in_bytes and get_bytes_per_pixel for Y8 image.
There was a problem hiding this comment.
I totally agree with you, but there is one issue. We are trying to keep the network extensions library "external" to the main librealsense code. It means we cannot use "librealsense" namespace and we do use include files from the "src" directory. I will think about the solution for this issue. Any suggestions are welcome.
There was a problem hiding this comment.
I think, these code should be moved to rs_rtp_stream::rs_rtp_stream() method. /src/ethernet/rs_rtp_stream.hh
|
@apuzhevi , check the CI report and rectify accordingly |
ev-mp
reviewed
Feb 2, 2021
ev-mp
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.