Replaced Deprecated function mktemp to TemporaryFile #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karina-ranadive
changed the title
|
Hi @karina-ranadive I'm adding a reference link describing the differences Approving the PR. |
SamerKhshiboun
approved these changes
Jul 21, 2023
|
Awesome, thank you so much!
…On Thu, Jul 20, 2023 at 9:19 PM Samer Khshiboun ***@***.***> wrote:
Hi @karina-ranadive <https://github.com/karina-ranadive>
Thanks for the fix.
I'm adding a reference link describing the differences
https://docs.python.org/3/library/tempfile.html
Approving the PR.
—
Reply to this email directly, view it on GitHub
<#2817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASPTGNYP7SUUVDFEU7CQNBLXRHKJ3ANCNFSM6AAAAAA2QNVWZU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mktemp function in launch launch_utils.py presents a security vulnerability for my team that utilizes realsense-ros. To fix this, I utilized the function TemporaryFile which has the same purpose as mktemp but is a safe function to use whereas mktemp is a call to a deprecated function, which can be insecure.