Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RGBD + reduce changes between hkr and development #2830

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add RGBD + reduce changes between hkr and development #2830

merged 2 commits into from
Aug 3, 2023

Conversation

SamerKhshiboun
Copy link
Collaborator

  • add RGBD to development
  • Reduce changes between hkr and development

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review August 1, 2023 11:45
@SamerKhshiboun SamerKhshiboun force-pushed the ros2-reduce-changes-with-hkr branch 2 times, most recently from 76957d6 to 6d62b99 Compare August 1, 2023 13:33
@Nir-Az
Copy link
Collaborator

Nir-Az commented Aug 1, 2023

Can we add some tests for RGBD?

@SamerKhshiboun
Copy link
Collaborator Author

Can we add some tests for RGBD?

I added a separate ticket for this.
I want to align between the two branches.
Then I will start adding tests.

@Nir-Az Nir-Az self-requested a review August 3, 2023 13:39
@Nir-Az Nir-Az merged commit 5b5dbc8 into IntelRealSense:ros2-development Aug 3, 2023
6 checks passed
@SamerKhshiboun SamerKhshiboun deleted the ros2-reduce-changes-with-hkr branch August 6, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @Nir-Az