fix readme and nodefactory for ros2 run #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamerKhshiboun
force-pushed
the
fix-readme-and-nodefactory
branch
from
76b7104 to
30a70e1
Compare
Nir-Az
reviewed
Aug 29, 2023
| @@ -183,6 +184,74 @@ | |||
|
|
|||
| <hr> | |||
|
|
|||
| <h3 id="camera-name-and-namespace"> | |||
There was a problem hiding this comment.
Please remember we will have to notify this change.
To validation to get ready for it, and other internal users as well
What will happen to users that doesn't change there launch file?
Maybe we need a red notice here about this change?
Let's speak and see how we can make a smooth transition as possible.
There was a problem hiding this comment.
I can use these kinds of notifications in the top of the README page
https://github.com/orgs/community/discussions/16925
We can tell validation and internal users about this before we merge this into SC branches.
There was a problem hiding this comment.
Looks like a good option..
Nir-Az
approved these changes
Aug 31, 2023
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in RSDEV-472