Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device ID of D405 #2915

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix device ID of D405 #2915

merged 1 commit into from
Oct 29, 2023

Conversation

rhaschke
Copy link
Contributor

The camera is not found with the original ID. Please check!

@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 29, 2023

Hi @rhaschke ,
We currently do not support ROS1 and only focus on ROS2 development.

Looks like the actual D405 PID was never introduced to ROS1 code.
Since this camera is a special case (color stream from depth module), I am not sure this camera will work without code changes and we cannot support this currently.

If you still need it, I suggest forking this branch and verifying this change works for you.

Thanks

@rhaschke
Copy link
Contributor Author

Of course, I verified that the camera works with this fix - both RGB and depth streams.
Would be great if you consider this minor fix to also make the camera available to other users.
Thanks

@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 29, 2023

Of course, I verified that the camera works with this fix - both RGB and depth streams. Would be great if you consider this minor fix to also make the camera available to other users. Thanks

No problem since you verified it we will help and merge it.
FYI, no future release of ROS1 packages is planned.
Thanks for the PR

@Nir-Az Nir-Az merged commit de76e14 into IntelRealSense:ros1-legacy Oct 29, 2023
1 of 2 checks passed
@rhaschke
Copy link
Contributor Author

Thanks for merging.

FYI, no future release of ROS1 packages is planned.

That's fine. I am co-maintaining the ROS One release, thus we release ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants