Support Triggered Calibration as ROS2 Action #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamerKhshiboun
force-pushed
the
tc_v1
branch
3 times, most recently
from
453ada5 to
b8b2308
Compare
Nir-Az
reviewed
Jun 23, 2024
| @@ -0,0 +1,121 @@ | |||
| // Copyright 2024 Intel Corporation. All Rights Reserved. | |||
There was a problem hiding this comment.
actions.cpp is a generic name.
Do we want a calibration action dedicated name instead ?
There was a problem hiding this comment.
I think we will add all actions in the future inside it (we can add FW-update action for example, etc..)
(In the same way, I will create a "services.cpp" file for all services - we can redesign this in a separate task)
There was a problem hiding this comment.
On next action/service please consider creating a service/action folder and implement a file for each serve/action
With time it may grow..
Nir-Az
reviewed
Jun 23, 2024
|
Looks great overall :) |
Nir-Az
approved these changes
Jun 23, 2024
SamerKhshiboun
merged commit 598756b
into
IntelRealSense:ros2-development
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on RSDEV-2204
Based on:
https://design.ros2.org/articles/actions.html
https://docs.ros.org/en/jazzy/Tutorials/Intermediate/Writing-an-Action-Server-Client/Cpp.html#writing-an-action-server