Changed the decompression library from gzip-js to pako #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeinerLP
approved these changes
Jan 27, 2024
PierreSchwang
requested changes
Jan 27, 2024
|
Thanks for the PR, please rebase your branch to address the conflicts @naguam |
Pako is fast maintained and modern contrary to gzip-js Pako does not hang on gzip files > 1MB by using too much memory in an array for node as does gzip-js The size limit must always be defined by configuration, not library capabilities.
|
Rebased my commits on top of the main branch |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replacement from gzip-js to pako for the gunzip decompression in the Update route.
Description
Pako is a fast and maintained gzip compression/decompression library.
Gzip-js is not so maintained and crashes on files > 1MB because of node limits on array expansions.
Tested with files of a few KB, 1MB, 10MB and 30 MB.
This does not change the fact we set a limit in the configuration.
But with this commit if the limit is high, it does not crash anymore.