feat: allow NBT on wand items #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Jun 2, 2024
dordsor21
commented
- closes NBT on items in configuration file #2383
SirYwell
approved these changes
Jun 2, 2024
| } | ||
| player.giveItem(new BaseItemStack(itemType, 1)); | ||
| System.out.println("a "+ wand); |
PierreSchwang
approved these changes
Jun 2, 2024
I tested setting damage to an axe and it worked so I called it okay. No idea how the specific use in the issue would work but Minecraft has forever allowed for custom NBT on basically everything so there's no reason for NBT that is consequently picked up by something else to be set (and incidentally I tested this because of the toLowerCase on the config strings as damage is "Damage" in NBT :) ) |
NotMyFault
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.