Improve BiomeMask performance #3082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+303
to
+314
| class BiomeTypeIdCache { | ||
| private static final List<BiomeType> byId = create(); | ||
|
|
||
| private static List<BiomeType> create() { | ||
| BiomeType[] array = values().toArray(new BiomeType[0]); | ||
| Arrays.sort(array, Comparator.comparing(BiomeType::getLegacyId)); | ||
| return List.of(array); | ||
| } | ||
|
|
||
| } | ||
| if (legacyId >= 0 && legacyId < BiomeTypeIdCache.byId.size()) { | ||
| return BiomeTypeIdCache.byId.get(legacyId); |
There was a problem hiding this comment.
Any specific reason on using a List instead of an array?
There was a problem hiding this comment.
Not really, the list is immutable and its backing array is marked stable which might help performance in some cases, but it likely doesn't matter.
There was a problem hiding this comment.
Yeah I think any performance drops from using a list should be compiled away given it's a static final list, so it should just act as an array in runtime
dordsor21
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
BiomeMask and biome access generally are rather slow, and a lot of the slowness is caused by inefficient translation and slow contains checks. The adaption from NMS biomes to WE BiomeType can be simplified as we already set the legacy id (= NMS-internal id). The HashSet can be replaced by a boolean array, similar to how BlockMask works.
Submitter Checklist