Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ProtocolLib v5, which is needed for 1.19.x #106

Merged
merged 5 commits into from
Aug 7, 2022
Merged

Support for ProtocolLib v5, which is needed for 1.19.x #106

merged 5 commits into from
Aug 7, 2022

Conversation

Aurelien30000
Copy link
Member

@Aurelien30000 Aurelien30000 commented Jul 30, 2022 •
edited
Loading

Description

Fix new ProtocolLib v5 compatibility (dmulloy2/ProtocolLib@c5f0550#diff-f426eb275d8141d8a8a4cf508752cfdad77b635bfc5d2b52561f2b3555073b34).

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@Aurelien30000 Aurelien30000 requested a review from a team as a code owner July 30, 2022 20:39
NotMyFault
NotMyFault reviewed Aug 6, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission cleanup should be its own PR, otherwise lgtm.

@Aurelien30000 Aurelien30000 changed the title ProtocolLib fix + API usage fix ProtocolLib fix Aug 7, 2022
@NotMyFault NotMyFault changed the title ProtocolLib fix Support for ProtocolLib v5 Aug 7, 2022
@NotMyFault NotMyFault added the Feature This PR adds a new feature label Aug 7, 2022
NotMyFault
NotMyFault approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@NotMyFault NotMyFault requested a review from a team August 7, 2022 13:50
@NotMyFault NotMyFault merged commit 8f2ceea into IntellectualSites:main Aug 7, 2022
@NotMyFault NotMyFault changed the title Support for ProtocolLib v5 Support for ProtocolLib v5, which is needed for 1.19.x Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@SirYwell SirYwell SirYwell approved these changes

Assignees
No one assigned
Labels
Feature This PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aurelien30000 @SirYwell @NotMyFault