#59 - Support CancellationToken in DataSources #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamskt
previously approved these changes
Jan 8, 2020
|
The changed Vue files in this case are just the horribly outdated ad-hoc testbed. I want to hold off on merging this until I see what MS intends to do on that EF Core issue I posted, because right now, cancellations will pollute your logs to death with errors that aren't really errors. |
ascott18
force-pushed
the
ascott/59-data-source-cancelltion
branch
from
c883bf8
to
2dce819
Compare
CancellationToken usage in StandardDataSource disabled by default to work around EF's default logging of cancellations.
ascott18
force-pushed
the
ascott/59-data-source-cancelltion
branch
from
2dce819
to
824e1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently its a bit annoying to use because EF will log cancellations. dotnet/efcore#19526