Unused variable lambda #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
May 21, 2020
| } | ||
|
|
||
| [TestMethod] | ||
| public void LambdaMethodWithDiscard_NoDiagnosticInformationReturned() |
There was a problem hiding this comment.
Isn't this the same as the first test? Should this be testing the opposite case confirming the un-used lambda parameters are flagged
There was a problem hiding this comment.
I honestly wasn't sure, so figured I'd err on the side of caution. :) If having or not having braces is fundamentally the same, I can remove the test.
But, yes, I did forget to add tests for the opposite case. I will do that now!
Keboo
approved these changes
May 21, 2020
|
Just for posterity this solution aligns with the C# 9.0 candidate feature for allowing lambda discard parameters. dotnet/csharplang#111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #104