rename getEnergy -> getStoredEnergy #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to prevent the method conflict with CC:Tweaked's energy_storage generic peripheral resolve IntelligenceModding#642
|
That the check is not successful makes no sense |
SirEndii
merged commit 8222f8d
into
IntelligenceModding:dev/1.20.1
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Powah's stuff's getEnergy will return an integer since there is a same name method in cc:t
What is the new behavior (if this is a feature change)?
After rename it will not conflict anymore, and should return a double now
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
No
Other information:
1.19.2 do not have this bug, but I do not know if I still need to add a method called
getStoredEnergyin 1.19.2