Allow operation cooldown to be 0 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution, but please keep in mind for the next time to make your changes for the oldest fully supported version as stated in the guidelines |
|
Ah, sorry, do you mean targeting the PR for the older branch? Should I rebase #667 in that case? |
2 tasks
|
I am sorry that I didn't answer @Niki4tap It would be neat if you can rebase to 1.19.2/implement it in 1.19.2 due to my lack of time currently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, ...)
Allows for the cooldown to be set to 0, the default cooldown is still the same, so this doesn't change anything for most players, and allows for the folks who know what they're doing to lift the cooldown altogether.
What is the current behavior? (You can also link to an open issue here)
Cooldown is set to at least 1000, and currently cannot be lower (unless you are going to patch the mod which I did in my survival world but wanted to upstream the changes)
What is the new behavior (if this is a feature change)?
Described above.
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
None, config change.
Other information:
It's fine if this change cannot be upstreamed due to security concerns or whatever, I can still patch and build the mod myself for my worlds, but the cooldown can really get annoying if you're using the vanilla mod, and especially busy looping to wait for a message to leave the computer and sent in the chat makes the players want to code some sort of a "message sender domain" which is crazy as hell for this small thing, but is necessary for the correct and timely operation of computers, or if one trusts every computer on the server (you're playing only with a friend, not a public server), you could just lift the cooldown altogether and stop worrying about it.