Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distant detector patch #671

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Dec 17, 2024

  • add volatile keyword to DistanceDetector fields
  • fix distance detector max distance behaviour
  • fix double float convert
  • Persistence distance detector settings

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix, feature

  • What is the current behavior? (You can also link to an open issue here)
    Distant detector does not return exact distance the entity/block model has

  • What is the new behavior (if this is a feature change)?
    Use volatile/atomic to ensure fields can be safely share between threads
    Make block hit & entity hit check more accurate
    Persistence distance detector settings

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    No

  • Other information:

@zyxkad zyxkad marked this pull request as ready for review December 18, 2024 19:09
@zyxkad zyxkad requested a review from SirEndii December 18, 2024 19:09
@SirEndii
Copy link
Member

The cleanup and changes look good, the thing really needed some love

@SirEndii SirEndii merged commit ab8dca7 into IntelligenceModding:dev/0.8 Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants