Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the lib's binding API #145

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

vcharpenay
Copy link
Contributor

The code base to merge has a generic API for protocol bindings. See the entry point bindings.ProtocolBindings. Clients can initiate operations without knowledge of the underlying protocol (HTTP, CoAP or anything else), as suggested in #72.

HTTP and CoAP bindings have been updated accordingly. Other protocol bindings are available for OPC-UA and for ROS.

The README isn't up to date regarding e.g. TdHttpRequest. It should be updated before merging.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 61.62% and project coverage change: -2.07 ⚠️

Comparison is base (e48a1d4) 87.53% compared to head (ea17fda) 85.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
- Coverage     87.53%   85.46%   -2.07%     
- Complexity      504      547      +43     
============================================
  Files            43       53      +10     
  Lines          1901     2071     +170     
  Branches        254      283      +29     
============================================
+ Hits           1664     1770     +106     
- Misses          161      220      +59     
- Partials         76       81       +5     
Impacted Files Coverage Δ
...nisg/ics/interactions/wot/td/affordances/Link.java 0.00% <0.00%> (ø)
...wot/td/bindings/BindingNotRegisteredException.java 0.00% <0.00%> (ø)
...ractions/wot/td/bindings/InvalidFormException.java 0.00% <0.00%> (ø)
...s/interactions/wot/td/security/SecurityScheme.java 100.00% <ø> (ø)
...ions/wot/td/security/TokenBasedSecurityScheme.java 100.00% <ø> (ø)
...unisg/ics/interactions/wot/td/vocabularies/TD.java 0.00% <ø> (ø)
...eractions/wot/td/bindings/coap/TDCoapResponse.java 66.66% <20.00%> (ø)
...ractions/wot/td/bindings/coap/TDCoapOperation.java 40.00% <40.00%> (ø)
...ractions/wot/td/bindings/http/TDHttpOperation.java 48.27% <48.27%> (ø)
...eractions/wot/td/bindings/NoResponseException.java 50.00% <50.00%> (ø)
... and 12 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danaivach
Copy link
Collaborator

Hi @vcharpenay, I have this PR in mind to be looked this week (also see how to increase coverage to target).

Would you consider the branch stable enough to be merged with main?

@vcharpenay
Copy link
Contributor Author

We've used this version of the lib in the ai4industry summer school last week. I also used it in another project. The binding API has been quite stable since then, and we haven't found bugs in the HTTP binding so far. I haven't tried to integrate the CoAP binding, though. I don't have a test bed for that.

@danaivach
Copy link
Collaborator

@vcharpenay is the README up to date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants