Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSON-LD 1.1 support (only writer) #56

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

samubura
Copy link
Collaborator

This should be working fine and converting from the TDModel to a JSON-LD 1.1 representation.
Still need to test a few things that we can maybe discuss together.

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #56 (945f086) into master (886ec3f) will increase coverage by 1.16%.
The diff coverage is 91.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     83.49%   84.65%   +1.16%     
- Complexity      256      338      +82     
============================================
  Files            30       35       +5     
  Lines          1018     1245     +227     
  Branches        119      141      +22     
============================================
+ Hits            850     1054     +204     
- Misses          114      125      +11     
- Partials         54       66      +12     
Impacted Files Coverage Δ
...eractions/wot/td/affordances/ActionAffordance.java 100.00% <ø> (ø)
...actions/wot/td/affordances/PropertyAffordance.java 100.00% <ø> (ø)
.../ch/unisg/ics/interactions/wot/td/io/TDWriter.java 33.33% <33.33%> (ø)
...nisg/ics/interactions/wot/td/ThingDescription.java 68.04% <66.66%> (-0.05%) ⬇️
...ch/unisg/ics/interactions/wot/td/io/json/JWot.java 75.00% <75.00%> (ø)
.../ics/interactions/wot/td/schemas/ObjectSchema.java 85.45% <75.00%> (ø)
.../interactions/wot/td/io/json/SchemaJsonWriter.java 82.22% <82.22%> (ø)
.../ics/interactions/wot/td/io/json/TDJsonWriter.java 92.98% <92.98%> (ø)
...nisg/ics/interactions/wot/td/affordances/Form.java 90.90% <100.00%> (ø)
...ions/wot/td/affordances/InteractionAffordance.java 87.50% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886ec3f...945f086. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants