-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated spec to reflect the changes for GPP API v1.1 and for IAB EU TCF v2.2 #70
Conversation
fixed 2 typos in sample stub code
…ple places that were showing integer
…tListener, and removeEventListener callbacks in example stub code
Resolves issue #37
fixed status codes
Update all commands to rely solely on callbacks
New event statuses
Formatting of the getSection API command
While implementing the changes into our code, we found that the event order is not explizit enough, especially when vendors will start relying on "signalStatus" event. I'd therefore suggest to add some clarification to addEventListerner or another place. Suggested text (please check & correct my english): Event order Example 1:
Example 2:
|
if(__gpp) //if only the TCString is needed, it get be taken directly from pingData.gppString //get the data from the TCF Canada section var vendorConsent = data[0].VendorExpressConsent;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the references to tcfcav1 and tcfcav2 in this document appear incorrect according to
<td>tcfca</td> |
as noted in the meeting, would be very helpful to see @janwinkler 's excellent parsedSections suggestion return parsedSections: {tcfcav1: [{SID : 5}, {Version; 1 ...}, {...} ], or something of that nature [ eg applicableAPIs], so maintaining sid to api maps will not be necessary for every api consumer. |
While I like the The other, hidden suggestion in @patmmccann comment would solve the mapping problem: include the SID in each section. Perhaps {
sid: 7,
api: "usnat",
subSections: [
/* Core Sub-section */
{
Version:1,
Created: Date (Thu Apr 13 2023 18:07:12 GMT+0200),
LastUpdated: Date (Thu Apr 13 2023 18:07:12 GMT+0200),
CmpId: 31,
CmpVersion: 123,
ConsentScreen: 5,
...
},
/* Publisher Purposes Sub-section (optional) */
{
subsectionType:3,
PubPurposesExpressConsent : [1,2,3,4,5],
PubPurposesImpliedConsent : [6,7,8,9],
...
}
]
} |
@dgirardi @patmmccann although im not against adding the section IDs, Im still not sure I understand the issue with the mapping: |
It isn't; the issue is maintaining the mapping. And as we see in #73 ; not even existing mappings can be considered stable. Publishers often take years to upgrade header bidding libraries. Prebid understanding a new mapping shouldn't require a software library upgrade. The cmp should present the mappings to its consumers. |
@patmmccann But thats what i mean: once the mapping is created, it should never change (the recent changes i see more as a bug in the spec an not a real change). hence the only situation when you would need to update your mapping, is when you anyway work on your code to support a new legislation or new tcf version or something. anyhow, lets cut the conversation here and add the sid to the section and make us all happy ;-) |
Fix Canada api name references in GPP 1.1
Added parsedSection to pingReturn object, updated the date referenced in applicableSections from July 1, 2023 to September 30, 2023.
Added parsedSection to pingReturn object
parsedSections in pingReturn object
- Added section id to supportedAPIs - Updated the code examples to match updated supportedAPIs
Updated supportedAPIs to include sectionid map
Added section id to supportedAPIs Updated the code examples to match updated supportedAPIs
Great work! |
@@ -247,32 +248,6 @@ The publisher purposes segment is appended to the core segment by using the “. | |||
|
|||
# Client side API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Client side API | |
# Client side API |
Open for public comment until May 26th, 2023
Changes in this PR to support GPP API v1.1
Changes in PR to support TCF 2.2: