fix(audience-taxonomy): fix audience with identical ID and parent ID #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello IAB Tech Lab,
I discovered a little issue in the current version of the Audience Taxonomy 1.1 TSV file in this repository.
The
Purchase Intent* | Family and Parenting | Day Care Centers |category indicated it self as parent (sameUnique IDasParent ID).While fixing this issue I also noticed that two child categories were missing a parent's name in it's condensed name:
Purchase Intent* | Family and Parenting | Nanny Services |(parent ID:1379) =>Purchase Intent* | Family and Parenting | Childcare | Nanny Services |Purchase Intent* | Family and Parenting | Genealogy and Family Trees |=>Purchase Intent* | Family and Parenting | Childcare | Nanny Services |Four children also had incorrect
Parent IDswhich I also fixed in this PR.Let me know if you have any questions.