Add Joystick "Back" Button #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new button action that allows players to back out of UI screens with a button on the controller, just like how the escape key is used to back out of UI screens on the keyboard. Key binding can be set in the joystick controller configuration dialog. Pause key binding renamed in code so it isn't confused with the UI exit binding.
* Renaming the UiExit key binding to Back * extending the joystickUICache to hold the Back Key * moving key checking functions to be closer to the other similar mouse functions in inputmanager * ensuring that the controller is enabled before checking the back button is pressed
Renaming GetBackKey functions to GetBackButton since the name Button makes more sense for a controller button.
- Issue caused by renaming 'Escape' Action enum to 'Pause'
- Unused in game so far, but could be used by modders
- The DFU method was accidentally considering secondary keybind equivalents which is unnecessary + causes overhead
- Turns out we did need that function after all
|
Thank you @jefetienne. I'll finish review on this one soon and aim to merge ahead of next release. Cheers! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased #2367 to fix conflicts from upstream and also applied a couple other needed fixes for the pull request.
@argonius2 I assume you want to have credit as well which is why I have kept your commits!